datadeps: Don't skip copy on no writedep #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
force-pushed
the
jps/datadeps-no-haswritedep
branch
3 times, most recently
from
db9df26 to
1359bd0
Compare
jpsamaroo
force-pushed
the
jps/datadeps-no-haswritedep
branch
from
1359bd0 to
36b269c
Compare
jpsamaroo
force-pushed
the
jps/datadeps-no-haswritedep
branch
from
f98c4bc to
96b4f89
Compare
|
Julia 1 failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's incorrect to skip on just this, because we might still need to copy for the purpose of adapting types, e.g. CPU -> GPU.