Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ROJ v0.1.0 #124209

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 493365b4-7e18-460b-8b90-ec3e7f80d3eb
Repo: https://github.com/Michi-Tsubaki/ROJ.jl.git
Tree: 5b089016e72131f05089254fd196154c411276dd

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Feb 2, 2025

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
  • Name is not at least 5 characters long
  • I was not able to load the package (i.e. import ROJ failed). See the AutoMerge logs for details.
  • Package name similar to 8 existing packages.
    1. Similar to ROS. Damerau-Levenshtein distance 1 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1. Normalized visual distance 1.84 is at or below cutoff of 2.50.
    2. Similar to MLJ. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    3. Similar to RAI. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    4. Similar to QOI. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    5. Similar to Run. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    6. Similar to ROOT. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    7. Similar to SOM. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    8. Similar to Proj. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Feb 3, 2025

While acronyms like ROJ are very frowned upon in the Julia community, there are generally exceptions for wrapper packages, which usually can use the name of the wrapped package. That tends to be the least confusing for the user, and is often preferable to coming up with a "Julian" name. In fact, a package with a non-Julian name can serve as a signal that the package wraps something from another language.

I'm not really familiar with ROS, but it does seem like "ROS 1" and "ROS 2" are official names. For ROS 1, my understanding is that we have https://github.com/gstavrinos/ROS.jl by @gstavrinos (unmaintained?), and this package would target "ROS 2". As such, I think ROS2 might actually be the most appropriate name for this package. Of course, that absolutely does not pass the automatic rules, and would have to be merged manually by a registry maintainer. I would recommend checking in the #pkg-registration channel on Slack for some more community feedback on this.

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Feb 3, 2025
@goerz
Copy link
Member

goerz commented Feb 4, 2025

Closing in favor of #124282

@goerz goerz closed this Feb 4, 2025
@giordano giordano deleted the registrator-roj-493365b4-v0.1.0-98d0ed9bb7 branch March 5, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants