Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge SDL port into main #4

Merged
merged 28 commits into from
Dec 17, 2024
Merged

Merge SDL port into main #4

merged 28 commits into from
Dec 17, 2024

Conversation

JustDoom
Copy link
Owner

@JustDoom JustDoom commented Dec 17, 2024

Been working on the SDL port for a little while. Better performance, which is not really needed in this, and I wanted to learn how to use it. Also I think can replace one of the current dependencies later on

Summary by CodeRabbit

  • New Features

    • Introduced support for SDL graphics and audio, replacing SFML.
    • Added new classes for handling keyboard input and rendering.
    • Implemented a main menu interface for the emulator.
    • Added a timer class for managing time intervals.
  • Bug Fixes

    • Improved error handling for file operations and SDL initialization.
  • Documentation

    • Updated README to reflect changes in technology stack and dependencies.
  • Chores

    • Removed obsolete SFML files and configurations.
    • Updated build configurations to include new SDL dependencies.

Copy link

coderabbitai bot commented Dec 17, 2024

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 6800a11 and 945b3c7.

⛔ Files ignored due to path filters (1)
  • assets/icon.bmp is excluded by !**/*.bmp
📒 Files selected for processing (51)
  • .github/workflows/build.yml (2 hunks)
  • .gitmodules (1 hunks)
  • CMakeLists.txt (2 hunks)
  • README.md (2 hunks)
  • dependencies/CMakeLists.txt (1 hunks)
  • dependencies/libconfig (1 hunks)
  • dependencies/sdl (1 hunks)
  • dependencies/sdl_ttf (1 hunks)
  • dependencies/sfml (0 hunks)
  • src/CMakeLists.txt (1 hunks)
  • src/Timer.cpp (1 hunks)
  • src/Timer.h (1 hunks)
  • src/emulator/Cpu.cpp (1 hunks)
  • src/emulator/Cpu.h (1 hunks)
  • src/emulator/Keyboard.h (2 hunks)
  • src/emulator/Renderer.cpp (2 hunks)
  • src/emulator/Renderer.h (2 hunks)
  • src/emulator/Speaker.h (1 hunks)
  • src/main.cpp (2 hunks)
  • src/sdl/CMakeLists.txt (1 hunks)
  • src/sdl/Emulator.cpp (1 hunks)
  • src/sdl/Emulator.h (1 hunks)
  • src/sdl/InputHandler.cpp (3 hunks)
  • src/sdl/InputHandler.h (1 hunks)
  • src/sdl/MainMenu.cpp (1 hunks)
  • src/sdl/MainMenu.h (1 hunks)
  • src/sdl/Window.cpp (1 hunks)
  • src/sdl/Window.h (1 hunks)
  • src/sdl/emulator/CMakeLists.txt (1 hunks)
  • src/sdl/emulator/SdlKeyboard.cpp (1 hunks)
  • src/sdl/emulator/SdlKeyboard.h (1 hunks)
  • src/sdl/emulator/SdlRenderer.cpp (1 hunks)
  • src/sdl/emulator/SdlRenderer.h (1 hunks)
  • src/sdl/emulator/SdlSpeaker.cpp (1 hunks)
  • src/sdl/emulator/SdlSpeaker.h (1 hunks)
  • src/sdl/ui/CMakeLists.txt (1 hunks)
  • src/sdl/ui/TextButton.cpp (1 hunks)
  • src/sdl/ui/TextButton.h (1 hunks)
  • src/sfml/Emulator.cpp (0 hunks)
  • src/sfml/Emulator.h (0 hunks)
  • src/sfml/InputHandler.h (0 hunks)
  • src/sfml/MainMenu.cpp (0 hunks)
  • src/sfml/MainMenu.h (0 hunks)
  • src/sfml/emulator/CMakeLists.txt (0 hunks)
  • src/sfml/emulator/SfmlRenderer.cpp (0 hunks)
  • src/sfml/emulator/SfmlRenderer.h (0 hunks)
  • src/sfml/emulator/SfmlSpeaker.cpp (0 hunks)
  • src/sfml/emulator/SfmlSpeaker.h (0 hunks)
  • src/sfml/ui/TextButton.cpp (0 hunks)
  • src/sfml/ui/TextButton.h (0 hunks)
  • src/util/MiscUtil.h (1 hunks)
 __________________________________________________________________
< Fine-tuning the Enterprise's warp drive to avoid BSOD at warp 9. >
 ------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Tip

Migrating from UI to YAML configuration.

Use the @coderabbitai configuration command in a PR comment to get a dump of all your UI settings in YAML format. You can then edit this YAML file and upload it to the root of your repository to configure CodeRabbit programmatically.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JustDoom
Copy link
Owner Author

Ehhh weird AI. Do not remember adding that

@JustDoom JustDoom merged commit 330041c into master Dec 17, 2024
2 checks passed
@JustDoom JustDoom deleted the sdl branch December 17, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant