Minor improvements to README and shell.nix #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimpostor
reviewed
Apr 26, 2024
Some dependencies (e.g. mozjs_sys) need it to find clang, otherwise it tries to use the system clang: ``` Unable to find libclang: "the `libclang` shared library at /usr/lib/libclang.so.17.0.6 could not be opened: libLLVM-17.so: cannot open shared object file: No such file or directory" ``` The relevant check happens in clang-sys [0] and unfortunately we cannot use its llvm-config path on Nix (--prefix does not work), so we have to resort to setting LIBCLANG_PATH directly. We add llvm-config anyway via llvmPackages.llvm, as it is helpful to have when used with some other options (e.g. --libdir, which **does** work on Nix). [0] https://github.com/KyleMayes/clang-sys/blob/99f4007e0b304631850f34cc1be89ac74f593ab8/build/common.rs#L287
vimpostor
reviewed
Apr 26, 2024
vimpostor
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing this, I ran into a few minor issues:
This patch adds Servo’s workarounds for the first two in shell.nix, and documents the third in the README.