Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable recursion for callables in macros #1073

Merged
merged 3 commits into from
Feb 2, 2025

Conversation

xs5871
Copy link
Collaborator

@xs5871 xs5871 commented Jan 27, 2025

It started out as a fix to the documentation from zulip, and here we are.

for n in range(count, 0, -1):
yield '{n}\n'.format(n)
yield n * delay_ms
yield '#🎉; rm -rf /'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what the surprise is!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a different surprise:
curl -s -L https://raw.githubusercontent.com/keroserene/rickrollrc/master/roll.sh | bash

Copy link
Collaborator Author

@xs5871 xs5871 Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a wonderfull suggestion.
On second thought, let's maybe step back and come up with something that doesn't incite using KMK as a rubber ducky replacement or download and run potentially "untrusted" code. Something that's less edgy or malicious.
We could make it open the KMK docs in a browser tab for example.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the second thought I wanted to incite in a roundabout way!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason github isn't sending me any email notifications anymore.

@xs5871 xs5871 requested a review from claycooper February 1, 2025 21:14
@regicidalplutophage regicidalplutophage merged commit c551dbf into main Feb 2, 2025
3 checks passed
@regicidalplutophage regicidalplutophage deleted the feature-macro-recursion branch February 2, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants