-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename life support nodes to be less confusing for users and developers #2500
base: master
Are you sure you want to change the base?
Conversation
This change is hella breaking |
I'd recommend just changing the display name, not the internal name, and also putting your typo fixing in a separate PR |
Yes, indeed. TwistedGiraffe suggested that this be done with RP-1 4.0, along with some other save-breaking changes that should be done eventually.
I think this would only move the problem to developers, and cause yet more confusion. (relevant)
Woops, forgot that was in there, it's already in #2483. I will remove it from this. I recommend talking in #2491 btw, as this would require PR's in many different repo's. |
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
Fix #2491
Rename:
to:
Relevant:
KSP-RO/ROKerbalism#175
KSP-RO/RP1AnalyticsWebApp#22