Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename life support nodes to be less confusing for users and developers #2500

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Clayell
Copy link
Contributor

@Clayell Clayell commented Feb 6, 2025

Fix #2491

Rename:

titles:
Early Life Support and ISRU
Life Support and ISRU
Basic Life Support and ISRU
Improved Lift Support and ISRU

ids:
earlyLifeSupport
lifeSupportISRU
basicLifeSupport
improvedLifeSupport

to:

titles:
Rudimentary Life Support
Early Life Support
Basic Life Support
Improved Life Support

ids:
rudimentaryLifeSupport
earlyLifeSupport
basicLifeSupport
improvedLifeSupport

Relevant:
KSP-RO/ROKerbalism#175
KSP-RO/RP1AnalyticsWebApp#22

@siimav
Copy link
Contributor

siimav commented Feb 6, 2025

This change is hella breaking

@NovemberOrWhatever
Copy link
Contributor

I'd recommend just changing the display name, not the internal name, and also putting your typo fixing in a separate PR

@Clayell
Copy link
Contributor Author

Clayell commented Feb 6, 2025

This change is hella breaking

Yes, indeed. TwistedGiraffe suggested that this be done with RP-1 4.0, along with some other save-breaking changes that should be done eventually.

I'd recommend just changing the display name, not the internal name

I think this would only move the problem to developers, and cause yet more confusion. (relevant)

also putting your typo fixing in a separate PR

Woops, forgot that was in there, it's already in #2483. I will remove it from this.

I recommend talking in #2491 btw, as this would require PR's in many different repo's.

(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
(should be done with KSP-RO#2483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants