BattleTool and full message collection instead of summary #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
KarmaKamikaze
commented
Nov 1, 2024
•
KarmaKamikaze
commented
- We add the BattleTool, which will handle combat and battles between characters in the narrative
- It is possible to do sparring fights and mock battle doing harmless damage
- We provide an option to disable summarization of the narrative, instead sending the entire message collection each query
- This was added to properly compare the ReAct version of ChatRPG to the non-ReAct version.
- FindCharacter is better at finding the right character, using context messages, while returning no character when appropriate
- Added examples to FindCharacter instructions
- Switch to GPT-4o model
- Removed markdown in responses
- Fix environment and character loading after the initial campaign is presented by moving it to AfterRender
- Made saving run as a task so player can input their next action faster
- Added a progress spinner to indicate when the archivist is saving the campaign behind the scenes
summarize the narrative, instead sending the entire message collection
right character and returning none when appropriate
damniko
reviewed
Nov 6, 2024
| @@ -79,7 +79,7 @@ public ReActAgentChain( | |||
| string? gameSummary = null, | |||
| string inputKey = "input", | |||
| string outputKey = "text", | |||
| int maxActions = 10) | |||
| int maxActions = 20) | |||
Sarmisuper
approved these changes
Nov 7, 2024
This was
linked to
issues
Nov 11, 2024
…ting. (This does make it seem a bit weird to the user though as they dont know when the game is finished updating the campaign with new characters.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.