Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Dashboard and finalizing login page #35

Merged
merged 40 commits into from
Nov 14, 2023
Merged

Initial Dashboard and finalizing login page #35

merged 40 commits into from
Nov 14, 2023

Conversation

KarmaKamikaze
Copy link
Owner

@KarmaKamikaze KarmaKamikaze commented Nov 8, 2023 •
edited
Loading

This is a UI enhancement PR and thus should also be reviewed on the webpage in a running state in addition to the source code.

Summary of added content:

  • New unauthorized index page with typing logo and fading slogan.
    • Cool and immersive background image on index page.
    • Login and register buttons moved to a central location.
    • Smooth animated buttons that gives off that 'boomer tryin'a be zoomer' kinda vibes.
    • Removed navbar in top and side of screen since login functionality has moved to a central position.
  • New Dashboard page for authorzed users.
    • Tweaked navbar for our ChatRPG branding, allowing for logging out as well (I know, amazing stuff).
    • List box with previously played campaigns which players can choose to continue.
    • Area for creating a brand new campaign
      • Lets players choose a Campaign title, a Character name, and a custom starting scenario.
      • Prewritten starting scenarios can also chosen and adapted by the user.
  • Adds the ChatRPGTests project for unit/E2E tests

Relevant files for review:

  • ChatRPG/Pages/Index.razor
  • ChatRPG/Pages/Index.razor.cs
  • ChatRPG/Shared/LoginDisplay.razor
  • ChatRPG/Shared/MainLayout.razor
  • ChatRPG/Pages/UserCampaignOverview.razor
  • ChatRPG/Pages/UserCampaignOverview.razor.cs
  • ChatRPG/Pages/Shared/Navbar.razor

This pull request closes #32

@KarmaKamikaze KarmaKamikaze added the enhancement New feature or request label Nov 8, 2023
@KarmaKamikaze KarmaKamikaze self-assigned this Nov 8, 2023
@KarmaKamikaze KarmaKamikaze linked an issue Nov 8, 2023 that may be closed by this pull request
UI - Dashboard (Campaign selector) #32
Closed
KarmaKamikaze and others added 24 commits November 8, 2023 10:07
@KarmaKamikaze
Update About section
d1a2a58
@KarmaKamikaze
Background images and ensure consistant styling
df29060
@KarmaKamikaze
yeet SurveyPrompt
8049329
@KarmaKamikaze
yeet NavMenu
f324e5b
@KarmaKamikaze
Changed Index.razor to Code-Behind approach, adding partial class thr…
ecb804a 
…ough Index.razor.cs
@KarmaKamikaze
Make btn-send css class so we can standardize primary buttons
54c0e58
@KarmaKamikaze
Merge branch 'dev' into feature/dashboard-page
51c403f
@KarmaKamikaze
Add Code-Behind files to Campaign page
8e79cb5
@KarmaKamikaze
Fixed redirect to login and register page by force loading
a81a077
@KarmaKamikaze
Cool background only on unauthorized views
3d6d27d
@KarmaKamikaze
Fix buttons in LoginDisplay
7e29ee0
@damniko
Added UserCampaignOverview
7e11b3f
@damniko
fix merge
da61e6e
@KarmaKamikaze
Fix logout by passing User instead of IdentityUser (thank you Sarmilan)
6043718
@damniko
added persistance he he
e672c92
@damniko
Merge branch 'feature/dashboard-page' of https://github.com/KarmaKami…
ec7e00b 
…kaze/ChatRPG into feature/dashboard-page
@KarmaKamikaze
Cool buttons on the front page to entrice the ladies
b2145ec
@KarmaKamikaze
Merge branch 'feature/dashboard-page' of https://github.com/KarmaKami…
44c655e 
…kaze/ChatRPG into feature/dashboard-page
@KarmaKamikaze
Please Linda and fix document-start in Build.yaml
026e4ab
@KarmaKamikaze
Fix cached title text. Now renders smoothly every time, baby.
9e1b2f7
@KarmaKamikaze
Document methods in Index
2529069
@KarmaKamikaze
Document methods in Campaign
5c662d2
@KarmaKamikaze
Document methods in FileUtility and extract interface
35bad00
@KarmaKamikaze
Extract Code-Behind for UserCampaignOverview and change display order…
f23f351 
… for previous Campaigns
@KarmaKamikaze KarmaKamikaze changed the title Dashboard page (#32) Dashboard page Nov 12, 2023
@KarmaKamikaze KarmaKamikaze changed the title (#32) Dashboard page Dashboard page Nov 12, 2023
@KarmaKamikaze KarmaKamikaze changed the title Dashboard page Dashboard and login page Nov 12, 2023
@KarmaKamikaze
Add test project and ChatRPGFixture
3258e26 
Added a new project to contain unit- and E2E tests
A fixture is injected into the collection named E2E collection to make sure that a server is running when the E2E tests are run
A few initial test cases are constructed to test E2E elements of the Index page
@KarmaKamikaze
Better test case names
b10f271
@KarmaKamikaze KarmaKamikaze changed the title Dashboard and login page Initial Dashboard and finalizing login page Nov 13, 2023
@KarmaKamikaze KarmaKamikaze marked this pull request as ready for review November 13, 2023 17:37
damniko
damniko approved these changes Nov 13, 2023
View reviewed changes
ChatRPGTests/ChatRPGFixture.cs Show resolved Hide resolved
selectionator
selectionator approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@selectionator selectionator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser sgu nice ud! LGTM 👍

ChatRPG/Pages/Index.razor Show resolved Hide resolved
@KarmaKamikaze KarmaKamikaze merged commit 2e6f14f into dev Nov 14, 2023
3 checks passed
@KarmaKamikaze KarmaKamikaze deleted the feature/dashboard-page branch November 14, 2023 09:39
@KarmaKamikaze KarmaKamikaze linked an issue Nov 17, 2023 that may be closed by this pull request
End-To-End Tests #40
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damniko damniko damniko approved these changes

@selectionator selectionator selectionator approved these changes

@Sarmisuper Sarmisuper Sarmisuper approved these changes

@mirakst mirakst Awaiting requested review from mirakst

Assignees

@KarmaKamikaze KarmaKamikaze

Labels
enhancement New feature or request
Projects
No open projects
P7 Kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

End-To-End Tests UI - Dashboard (Campaign selector)
4 participants
@KarmaKamikaze @damniko @Sarmisuper @selectionator