-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/open ai api improvements #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ser skide godt ud, Mikkel! Jeg har ikke lige kunne teste flowet ift. streaming af text fra APIen, men jeg har lagt lidt comments i mellemtiden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Har kun suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Efter var
er blevet yeetet er der kommet en smule build warnings, som lige bør fixes inden merge.
ChatRPG/Areas/Identity/RevalidatingIdentityAuthenticationStateProvider.cs
Outdated
Show resolved
Hide resolved
ChatRPG/Areas/Identity/RevalidatingIdentityAuthenticationStateProvider.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Godt arbejde!
Could re-add old OpenAiLlmClient and still use it for non-streamed requests. However, the nuget package works fine as well and I was able to do everything with it that I found necessary.
All files except ChatRPG.csproj are relevant for review.
This pull request closes #23