Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard Campaign Deletion Modal #48

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Dashboard Campaign Deletion Modal #48

merged 6 commits into from
Nov 21, 2023

Conversation

KarmaKamikaze
Copy link
Owner

@KarmaKamikaze KarmaKamikaze commented Nov 20, 2023 •
edited
Loading

This is a UI enhancement PR and thus should also be reviewed on the webpage in a running state in addition to the source code.

Summary of added content:

  • Improvements to the Dashboard page
    • Campaigns can now be deleted with delete button on campaign cards
    • Deletion confirmation modal
    • E2E tests of the modal component

Relevant files for review:

  • ChatRPG/Pages/ConfirmModal.razor
  • ChatRPG/Pages/UserCampaignOverview.razor
  • ChatRPG/Pages/UserCampaignOverview.razor.cs
  • ChatRPG/Services/EfPersisterService.cs

This pull request closes #50

@KarmaKamikaze KarmaKamikaze added the enhancement New feature or request label Nov 20, 2023
@KarmaKamikaze KarmaKamikaze self-assigned this Nov 20, 2023
This was linked to issues Nov 20, 2023
Implement - UI Play page #15
Closed
End-To-End Tests #40
Closed
@KarmaKamikaze KarmaKamikaze linked an issue Nov 20, 2023 that may be closed by this pull request
Delete campaign option #50
Closed
@KarmaKamikaze KarmaKamikaze changed the title Campaign page UI improvements Dashboard Campaign Deletion Modal Nov 20, 2023
@KarmaKamikaze KarmaKamikaze removed a link to an issue Nov 20, 2023
Implement - UI Play page #15
Closed
@KarmaKamikaze KarmaKamikaze marked this pull request as ready for review November 20, 2023 20:14
damniko
damniko approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@damniko damniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super godt - nu begynder det hele pludselig at falde på plads rent visuelt!

selectionator
selectionator approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@selectionator selectionator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Selenium tho' 🤮

@KarmaKamikaze KarmaKamikaze merged commit 90a3f10 into dev Nov 21, 2023
3 checks passed
@KarmaKamikaze KarmaKamikaze deleted the feature/campaign-ui branch November 21, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selectionator selectionator selectionator approved these changes

@Sarmisuper Sarmisuper Sarmisuper approved these changes

@damniko damniko damniko approved these changes

Assignees

@KarmaKamikaze KarmaKamikaze

Labels
enhancement New feature or request
Projects
No open projects
P7 Kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete campaign option End-To-End Tests
4 participants
@KarmaKamikaze @damniko @Sarmisuper @selectionator