-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add build target for vkcube-display #1027
Conversation
Add a new CMake target for vkcube-display, which the variant using VK_KHR_display. This is a variant which already exists, but is currently hard to build as only one variant can be selected per build using CUBE_WSI_SELECTION. With this option, it is possible to build this variant in addition to other ones, similar to what is done for vkcube-wayland. Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Author enunes not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
Author enunes not on autobuild list. Waiting for curator authorization before starting CI build. |
I want to state that while this PR is welcome, the solution is more of a band-aid than a long term fix. The root cause is vkcube being unable to choose the WSI platform at runtime. |
I agree that a refactor is better either by reworking the CMake logic or choosing the WSI at runtime. If you're already working on it then that will be better. So I can help review the new PR when it arrives and maybe we can drop this one. |
Closing in favor of #1029 |
That is exactly the reason that vkcube should have supported multiple WSI platforms at the same time, but alas it was easier to just copy-paste the cmake code and tweak the build than it was to actually make it work. |
@charles-lunarg Thanks! I'll test the new PR and post some review feedback there shortly. |
Add a new CMake target for vkcube-display, which the variant using VK_KHR_display.
This is a variant which already exists, but is currently hard to build as only one variant can be selected per build using CUBE_WSI_SELECTION. With this option, it is possible to build this variant in addition to other ones, similar to what is done for vkcube-wayland.
As of now this only takes effect in Linux (same as the wayland one below it) as this is the only platform I'm able to test on.