Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for max uint256 amount in withdrawERC20 #333

Merged
merged 6 commits into from
Dec 27, 2024
+282 −33
Merged

Add handling for max uint256 amount in withdrawERC20 #333

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ec54702
Add handling for max uint256 amount in withdrawERC20 and correspondin…
ylv-io Dec 23, 2024
606a1dc
Update WithdrawWorkflow address in addresses.json for test artifacts …
ylv-io Dec 24, 2024
27c1b74
Enhance WithdrawWorkflow with WETH support, update constructor, add t…
ylv-io Dec 24, 2024
1a4bd8e
Add handling for max uint256 withdrawal in WithdrawWorkflow and corre…
ylv-io Dec 24, 2024
a095fea
Add safe address and fee handling to AaveWithdrawWorkflow, update tes…
ylv-io Dec 24, 2024
61fe5dc
Refactor BridgeWorkflow.sol to rename variables for clarity, update b…
ylv-io Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/access/workflows/WithdrawWorkflow.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ contract WithdrawWorkflow {
error NativeWithdrawalFailed();

function withdrawERC20(IERC20 asset, uint256 amount) external {
// If amount is max uint256, set it to the entire balance
if (amount == type(uint256).max) {
amount = asset.balanceOf(address(this));
}

address owner = _getOwner();
asset.safeTransfer({to: owner, value: amount});
}
Expand Down
12 changes: 12 additions & 0 deletions test/unit/access/WithdrawWorkflow.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,18 @@ contract WithdrawWorkflowTest is BaseTest {
assertEq(token.balanceOf(_user), defaultAmount);
}

function testWithdrawERC20__WhenAmountMax() public {
token.mint(address(accessPoint), defaultAmount);

bytes memory data =
abi.encodeWithSelector(WithdrawWorkflow.withdrawERC20.selector, IERC20(token), type(uint256).max);

vm.prank(_user);
accessPoint.execute(address(withdrawWorkflow), data);

assertEq(token.balanceOf(_user), defaultAmount);
}

function testWithdrawNative() public {
vm.deal(address(accessPoint), defaultAmount);

Expand Down
Loading