2. refactor: increase coverage and refactor tests structure #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 82.00% 83.01% +1.00%
==========================================
Files 8 8
Lines 428 424 -4
Branches 114 113 -1
==========================================
+ Hits 351 352 +1
- Misses 25 26 +1
+ Partials 52 46 -6
|
fedealconada
changed the title
rrecuero
requested changes
Jan 18, 2024
fedealconada
force-pushed
the
increase-coverage-2
branch
from
b9b2cee to
32ac296
Compare
fedealconada
changed the base branch from
main
to
modify-wallet-test-structure
fedealconada
force-pushed
the
increase-coverage-2
branch
2 times, most recently
from
b41be85 to
2f69616
Compare
fedealconada
changed the title
fedealconada
changed the title
fedealconada
changed the base branch from
modify-wallet-test-structure
to
main
fedealconada
force-pushed
the
increase-coverage-2
branch
from
2f69616 to
8cd0afb
Compare
rrecuero
reviewed
Jan 23, 2024
src/wallet/KintoWallet.sol
Outdated
| @@ -270,8 +273,13 @@ contract KintoWallet is Initializable, BaseAccount, TokenCallbackHandler, IKinto | |||
| bytes32 hash = userOpHash.toEthSignedMessageHash(); | |||
| // If there is only one signature and there is an app Key, check it | |||
| address app = _getAppContract(userOp.callData); | |||
| console.log("APP", app); | |||
rrecuero
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.