Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. refactor: re-structure wallet tests #48

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

fedealconada
Copy link
Contributor

No description provided.

Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a9a72c) 82.31% compared to head (8373ba8) 81.92%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   82.31%   81.92%   -0.39%     
==========================================
  Files           8        8              
  Lines         424      426       +2     
  Branches      113      114       +1     
==========================================
  Hits          349      349              
- Misses         27       29       +2     
  Partials       48       48              

see 1 file with indirect coverage changes

@fedealconada fedealconada marked this pull request as ready for review January 22, 2024 16:01
_entryPoint.handleOps(userOps, payable(_owner));
}

// function testWhitelist_revertWhen_AppNotRegistered() public {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this?

Copy link
Contributor

@rrecuero rrecuero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting these ones up

@fedealconada fedealconada changed the title refactor: re-structure wallet tests 1. refactor: re-structure wallet tests Jan 22, 2024
@fedealconada fedealconada merged commit 4b383c6 into main Jan 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants