Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fund faucet fix #50

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Fund faucet fix #50

merged 3 commits into from
Jan 22, 2024

Conversation

rrecuero
Copy link
Contributor

Uses call so we can send ETH to contracts

@rrecuero rrecuero requested a review from fedealconada January 20, 2024 06:46
Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (46e56a5) 81.73% compared to head (2d21d97) 81.77%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   81.73%   81.77%   +0.04%     
==========================================
  Files           8        8              
  Lines         427      428       +1     
  Branches      114      116       +2     
==========================================
+ Hits          349      350       +1     
+ Misses         30       27       -3     
- Partials       48       51       +3     
Files Coverage Δ
src/wallet/KintoWalletFactory.sol 66.66% <50.00%> (+0.62%) ⬆️

Copy link
Contributor

@fedealconada fedealconada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rrecuero rrecuero merged commit a0a9096 into main Jan 22, 2024
8 of 9 checks passed
@rrecuero rrecuero deleted the fund-faucet-fix branch January 22, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants