feat: add migration to upgrade contracts #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use |
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
fedealconada
force-pushed
the
fix-paymaster-and-wallet
branch
from
81c1b99 to
d858d95
Compare
rrecuero
reviewed
Jan 23, 2024
| KintoAppRegistryV3 _registryImpl = KintoAppRegistryV3(upgradeRegistry()); | ||
| KintoWalletV4 _walletImpl = KintoWalletV4(payable(upgradeWallet())); | ||
| KintoWalletFactoryV7 _factoryImpl = KintoWalletFactoryV7(upgradeFactory()); | ||
| KYCViewerV2 _kycViewerImpl = KYCViewerV2(upgradeKYCViewer()); |
There was a problem hiding this comment.
need to redeploy kyc viewer completely. The previous one is not usable because we didnt call disableInitializers
rrecuero
reviewed
Jan 23, 2024
| console.log(string.concat("KintoAppRegistryV3-impl: ", vm.toString(address(_registryImpl)))); | ||
| console.log(string.concat("KintoWalletV4-impl: ", vm.toString(address(_walletImpl)))); | ||
| console.log(string.concat("KintoWalletFactoryV7-impl: ", vm.toString(address(_factoryImpl)))); | ||
| console.log(string.concat("KYCViewerV2-impl: ", vm.toString(address(_kycViewerImpl)))); |
There was a problem hiding this comment.
add 'KYCViewer' and rename that to KYCViewerV1-impl
rrecuero
reviewed
Jan 23, 2024
| bytes memory bytecode = | ||
| abi.encodePacked(type(KintoAppRegistryV3).creationCode, abi.encode(address(_walletFactory))); | ||
|
|
||
| vm.broadcast(deployerPrivateKey); |
There was a problem hiding this comment.
transferOwnership to ledger before upgrade?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-paymaster-and-wallet #54 +/- ##
============================================================
+ Coverage 82.02% 82.24% +0.22%
============================================================
Files 8 8
Lines 445 445
Branches 123 123
============================================================
+ Hits 365 366 +1
Misses 35 35
+ Partials 45 44 -1
|
fedealconada
force-pushed
the
21th-migration
branch
from
eff9f4e to
4393e6a
Compare
rrecuero
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrades: