Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H02 fix: add KYC checks on addDepositFor #59

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

fedealconada
Copy link
Contributor

Adds KYC check on addDepositFor

@fedealconada fedealconada requested a review from rrecuero January 29, 2024 13:09
Copy link

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

@fedealconada fedealconada changed the title fix: add KYC checks on addDepositFor H02 fix: add KYC checks on addDepositFor Jan 29, 2024
@fedealconada fedealconada force-pushed the H02-lack-of-restrictions branch from 0a5ffa9 to 9cc3469 Compare January 29, 2024 14:35
@fedealconada fedealconada force-pushed the H02-lack-of-restrictions branch from 9cc3469 to abc1d1c Compare January 29, 2024 19:05
@fedealconada fedealconada force-pushed the H02-lack-of-restrictions branch from abc1d1c to fc2fccb Compare January 30, 2024 10:55
@fedealconada fedealconada changed the base branch from useropmaxcost-setter to main January 30, 2024 10:55
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebd6fb8) 94.34% compared to head (aabc829) 94.59%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   94.34%   94.59%   +0.25%     
==========================================
  Files           8        8              
  Lines         442      444       +2     
  Branches      122      125       +3     
==========================================
+ Hits          417      420       +3     
  Misses          2        2              
+ Partials       23       22       -1     
Files Coverage Δ
src/KintoID.sol 94.23% <100.00%> (-0.11%) ⬇️
src/paymasters/SponsorPaymaster.sol 94.59% <100.00%> (+1.73%) ⬆️
src/wallet/KintoWalletFactory.sol 96.36% <ø> (ø)

@fedealconada fedealconada merged commit 35317ef into main Jan 30, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants