Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyc viewer user info #67

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Kyc viewer user info #67

merged 5 commits into from
Feb 1, 2024

Conversation

rrecuero
Copy link
Contributor

  • Creates a single call so the frontend can fetch all user info in one single call
  • 10x reduction in frontend rpc calls
  • Adds migrations
  • Adds simple test

@rrecuero rrecuero requested a review from fedealconada January 31, 2024 22:34
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fbe2af8) 94.60% compared to head (555f042) 94.31%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   94.60%   94.31%   -0.30%     
==========================================
  Files           8        8              
  Lines         445      457      +12     
  Branches      125      128       +3     
==========================================
+ Hits          421      431      +10     
  Misses          2        2              
- Partials       22       24       +2     
Files Coverage Δ
src/KintoID.sol 94.23% <ø> (ø)
src/paymasters/SponsorPaymaster.sol 94.66% <ø> (ø)
src/viewers/KYCViewer.sol 90.00% <85.71%> (-2.31%) ⬇️
src/wallet/KintoWalletFactory.sol 95.00% <83.33%> (-1.37%) ⬇️

@fedealconada fedealconada force-pushed the kyc-viewer-inf branch 3 times, most recently from 214dcf7 to 72b794f Compare February 1, 2024 13:56
Copy link

github-actions bot commented Feb 1, 2024

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary

@fedealconada fedealconada force-pushed the kyc-viewer-inf branch 2 times, most recently from 2430c03 to d631bf2 Compare February 1, 2024 16:11
@fedealconada fedealconada merged commit 9662e90 into main Feb 1, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants