Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start creating new permissions for registration #2674

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josephsnyder
Copy link
Member

Introduce a new setting that determines what registration forms are shown as the pages are accessed:

PUBLIC (or not set) : All registration forms are available and non-users can register an account
PROJECTADMIN: The public form is hidden and users must be added via the "Manage project users" or "Manage users" by someone with Project Administrator priviliges or highter.

ADMIN: Only the Site administrators may register a new account via the two available forms.

DISABLED: All registration forms are disabled and registration must occur through a different means (via OAuth/LDAP).

@josephsnyder josephsnyder force-pushed the rework_registration_disabling branch from ecb7eef to ed4cdfc Compare January 22, 2025 14:21
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an initial round of comments I left after a quick pass through this. I'll probably have more comments later once this is no longer a draft.

.env.example Outdated Show resolved Hide resolved
app/Enums/RegistrationPermissionsLevel.php Outdated Show resolved Hide resolved
config/auth.php Outdated Show resolved Hide resolved
@josephsnyder josephsnyder force-pushed the rework_registration_disabling branch 3 times, most recently from 35afe82 to fedf702 Compare January 28, 2025 16:59
@josephsnyder josephsnyder force-pushed the rework_registration_disabling branch from fedf702 to 2157412 Compare February 4, 2025 19:13
Introduce a new setting that determines what registration forms are
shown as the pages are accessed:

PUBLIC (or not set) : All registration forms are available and non-users
can register an account
PROJECTADMIN: The public form is hidden and users must be added via
the "Manage project users" or "Manage users" by someone with Project
Administrator priviliges or highter.

ADMIN: Only the Site administrators may register a new account via
the two available forms.

DISABLED: All registration forms are disabled and registration must occur
through a different means (via OAuth/LDAP).
@josephsnyder josephsnyder force-pushed the rework_registration_disabling branch from 2157412 to 4df5038 Compare February 5, 2025 18:56
@josephsnyder josephsnyder marked this pull request as ready for review February 5, 2025 18:57
@williamjallen williamjallen added this to the v3.9 milestone Feb 5, 2025
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After thinking about this some more, I have come to doubt the merits of allowing global administrators or project administrators to set the password for new users in any circumstance. Instead, we could get roughly the same effect (allowing administrators to gatekeep the users allowed on the CDash instance) by simply allowing them to send invite-only signup links to email addresses. That way, users are always responsible for setting their own password.

Any thoughts on this?

@josephsnyder
Copy link
Member Author

@williamjallen, I think consistency would be best, whatever that is since the same global administrator would have different capabilities based on the page used to add the incoming user. Either way, we would be able to use the policy above to ensure that the form is hidden or displayed.

@williamjallen
Copy link
Collaborator

As per our in-person conversation, I'm converting this to a draft pending the resolution of the changes suggested in #2674 (review).

@williamjallen williamjallen marked this pull request as draft February 5, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants