Standardize header menus #2706
Merged
Standardize header menus #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
header-menu-refactor
branch
from
0d8f733 to
3bbfcba
Compare
williamjallen
force-pushed
the
header-menu-refactor
branch
from
3bbfcba to
b3b2232
Compare
williamjallen
force-pushed
the
header-menu-refactor
branch
from
b3b2232 to
67b6cb1
Compare
|
LGTM! I notice some inconsistencies with the options available in the menu (Test Query appears in some places but not in others) but I can't find an issue with the creation of the menu as a whole. |
josephsnyder
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header menus are created differently on AngularJS, Vue, and XSL pages. Since project information is now available everywhere at page load time, we can render that information immediately instead of making a separate request to fetch it. The upside of this is that users will see the content immediately.