Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gtest version #626

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

dstoup
Copy link
Collaborator

@dstoup dstoup commented Oct 27, 2020

No description provided.

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

1 similar comment
@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

Copy link
Member

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay in principle, not approved because of question re: patching (but not -1'd either).

Patches/GTest/Patch.cmake Outdated Show resolved Hide resolved
Doc/release-notes/master.txt Outdated Show resolved Hide resolved
@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

* master:
  Update release notes
  Remove support for OpenCV v2
  Patch Caffe Dependencies to prevent Caffe overwriting the HDF5 libs from find_package
  Create Caffe patch that overrides incorrect hdf5 lib search
  Update release notes
  Add VTK version 9.0.1
  Use the tar.gz files from the download site.
  Remove VTK 6
  Add HDF5 update, version 1.12.0
@dstoup dstoup force-pushed the update-gtest-version branch from bd7f552 to 3a7c355 Compare October 28, 2020 18:10
@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

@kwcvrobot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants