Added trim to title when adding bookmark

Signed-off-by: Philipp <p.koenig@blockbyte.de>
Kiuryy · Jan 29, 2019 · f2ec762 · f2ec762
1 parent d455d95
commit f2ec762
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/src/js/helper/dragndrop.js b/src/js/helper/dragndrop.js
@@ -125,7 +125,7 @@
                             const bookmarkObj = {
                                 index: entryPlaceholder.prevAll("li").length(),
                                 parentId: entryPlaceholder.parent("ul").prev("a").attr($.attr.id),
-                                title: title,
+                                title: title.trim(),
                                 url: url
                             };
 

diff --git a/src/js/helper/overlay.js b/src/js/helper/overlay.js
@@ -440,13 +440,15 @@
                 let urlValue = "";
 
                 if (type === "bookmark") { // default bookmark values -> current page information
-                    titleValue = $(document).find("head > title").eq(0).text();
+                    if ($(document).find("head > title").length() > 0) {
+                        titleValue = $(document).find("head > title").eq(0).text().trim();
+                    }
                     urlValue = location.href;
                 }
 
                 if (data && data.values) { // fill fields with given values
-                    titleValue = data.values.title || "";
-                    urlValue = data.values.url || "";
+                    titleValue = (data.values.title || "").trim();
+                    urlValue = (data.values.url || "").trim();
                 }
 
                 list.append("<li><h2>" + $(e.currentTarget).attr("title") + "</h2></li>");

diff --git a/src/js/helper/utility.js b/src/js/helper/utility.js
@@ -74,10 +74,14 @@
          * @returns {boolean}
          */
         this.isBackgroundConnected = () => {
-            const port = chrome.runtime.connect();
-            if (port) {
-                port.disconnect();
-                return true;
+            try {
+                const port = chrome.runtime.connect();
+                if (port) {
+                    port.disconnect();
+                    return true;
+                }
+            } catch (e) {
+                //
             }
             return false;
         };