Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsolete C++ syntax in DirectShow library #852

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

samhocevar
Copy link
Contributor

Compiling using a recent version of the C++ standard (/std:c++latest) will fail to build these two files:

2>kinc\Backends\System\Windows\Libraries\DirectShow\BaseClasses\transip.h(214,55): error C4596: 'Copy': illegal qualified name in member declaration
2>(compiling source file '../../../kinc/Backends/System/Windows/Sources/kinc/backend/windowscppunit.cpp')
2>kinc\Backends\System\Windows\Libraries\DirectShow\BaseClasses\videoctl.h(54,30): error C2385: ambiguous access of '{dtor}'
2>(compiling source file '../../../kinc/Backends/System/Windows/Sources/kinc/backend/windowscppunit.cpp')
2>kinc\Backends\System\Windows\Libraries\DirectShow\BaseClasses\videoctl.h(54,30):
2>could be the '{dtor}' in base 'IDirectDraw'
2>kinc\Backends\System\Windows\Libraries\DirectShow\BaseClasses\videoctl.h(54,30):
2>or could be the '{dtor}' in base 'CUnknown'
2>kinc\Backends\System\Windows\Libraries\DirectShow\BaseClasses\videoctl.h(54,30): error C3254: 'CAggDirectDraw': class contains explicit override '{dtor}' but does not derive from an interface that contains the function declaration
2>(compiling source file '../../../kinc/Backends/System/Windows/Sources/kinc/backend/windowscppunit.cpp')
2>kinc\Backends\System\Windows\Libraries\DirectShow\BaseClasses\videoctl.h(54,30): error C3244: 'CAggDirectDraw::~CAggDirectDraw(void)': this method was introduced by '<Unknown>' not by 'IDirectDraw'
2>(compiling source file '../../../kinc/Backends/System/Windows/Sources/kinc/backend/windowscppunit.cpp')

@RobDangerous RobDangerous merged commit 1d01456 into Kode:main Feb 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants