Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(konnect): add KonnectCloudGatewayNetwork CRD #268

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Feb 4, 2025

What this PR does / why we need it:

Maps https://docs.konghq.com/konnect/api/cloud-gateways/latest/#/Networks/create-network API.

Ref:

This PR doesn't add any specific validations for network fields.

Which issue this PR fixes

Fixes #269

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek self-assigned this Feb 4, 2025
@pmalek pmalek force-pushed the konnect-network-type branch 8 times, most recently from bf37118 to 6bd0f36 Compare February 4, 2025 12:00
@pmalek pmalek added this to the KGO v1.5.x milestone Feb 4, 2025
@pmalek pmalek marked this pull request as ready for review February 4, 2025 12:03
@pmalek pmalek requested a review from a team as a code owner February 4, 2025 12:03
@pmalek pmalek force-pushed the konnect-network-type branch from 6bd0f36 to 256b322 Compare February 4, 2025 12:03
@pmalek pmalek force-pushed the konnect-network-type branch 2 times, most recently from ed4b9d3 to 709e6a7 Compare February 5, 2025 17:40
@pmalek pmalek changed the title feat(konnect): add KonnectNetwork CRD feat(konnect): add KonnectCloudGatewayNetwork CRD Feb 5, 2025
@pmalek pmalek force-pushed the konnect-network-type branch from 709e6a7 to 3a28e99 Compare February 6, 2025 11:01
@pmalek pmalek force-pushed the konnect-network-type branch from c422aa1 to 10abde0 Compare February 6, 2025 13:22
@pmalek pmalek force-pushed the konnect-network-type branch from 10abde0 to 107b2d4 Compare February 6, 2025 17:47
@pmalek pmalek requested a review from mlavacca February 7, 2025 11:13
@@ -1,7 +1,7 @@
# renovate: datasource=github-tags depName=kubernetes/code-generator
kube-code-generator: "0.32.1"
# renovate: datasource=github-releases depName=kubernetes-sigs/controller-tools
controller-tools: "0.17.1"
controller-tools: "0.17.2-0.20250205103018-dac769d27bbe"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to workaround broken aliases support in controller-gen kubernetes-sigs/controller-tools#1136 (which wasn't released yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create KonnectNetwork CRD
2 participants