-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(konnect): add KonnectCloudGatewayNetwork CRD #268
Open
pmalek
wants to merge
7
commits into
main
Choose a base branch
from
konnect-network-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf37118
to
6bd0f36
Compare
6bd0f36
to
256b322
Compare
mlavacca
reviewed
Feb 5, 2025
ed4b9d3
to
709e6a7
Compare
Co-authored-by: Mattia Lavacca <lavacca.mattia@gmail.com>
709e6a7
to
3a28e99
Compare
c422aa1
to
10abde0
Compare
10abde0
to
107b2d4
Compare
pmalek
commented
Feb 7, 2025
@@ -1,7 +1,7 @@ | |||
# renovate: datasource=github-tags depName=kubernetes/code-generator | |||
kube-code-generator: "0.32.1" | |||
# renovate: datasource=github-releases depName=kubernetes-sigs/controller-tools | |||
controller-tools: "0.17.1" | |||
controller-tools: "0.17.2-0.20250205103018-dac769d27bbe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to workaround broken aliases support in controller-gen kubernetes-sigs/controller-tools#1136 (which wasn't released yet)
mlavacca
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Maps https://docs.konghq.com/konnect/api/cloud-gateways/latest/#/Networks/create-network API.
Ref:
This PR doesn't add any specific validations for network fields.
Which issue this PR fixes
Fixes #269
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect significant changes