Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate --gateway-discovery-dns-strategy - make discovery always work #7033

Merged
merged 4 commits into from
Jan 29, 2025

Update internal/manager/config.go

1ceee05
Select commit
Loading
Failed to load commit list.
Merged

feat: deprecate --gateway-discovery-dns-strategy - make discovery always work #7033

Update internal/manager/config.go
1ceee05
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

76.7% (-0.2%) compared to d4d18a4

View this Pull Request on Codecov

76.7% (-0.2%) compared to d4d18a4

Details

Codecov Report

Attention: Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.7%. Comparing base (d4d18a4) to head (1ceee05).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
internal/adminapi/kong.go 70.0% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #7033     +/-   ##
=======================================
- Coverage   76.9%   76.7%   -0.2%     
=======================================
  Files        214     213      -1     
  Lines      25169   25004    -165     
=======================================
- Hits       19356   19181    -175     
- Misses      4794    4817     +23     
+ Partials    1019    1006     -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.