Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging.basicConfig() to avoid conflict with clients #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

athyuttamre
Copy link

Calling logging.basicConfig() causes duplicate logging in client code. This is because clients that import devicecheck before setting up their own log handlers will end up with two log handlers.

Here's a simple repro: https://github.com/athyuttamre/devicecheck-repro

This PR removes this line from the package.

@Kylmakalle
Copy link
Owner

I appreciate the example, even for this one line diff.

You likely want to remove the logger configuration in init.py file as well

I think the reason for this line was my internal testing where I'm not setting up the basic configuration elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants