-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure job connections #323
Conversation
Thanks for submitting the PR. I'll review it and let you know if I have any feedback |
@abhihyder could you add or update the unit tests so that we have this change in coverage? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The action code looks great, but just wanted to have it covered by the existing unit tests or creating a new test. So we can confirm that the actions are executed on the correct connection.
Hi @Kyon147, Thank you for the feedback! I've updated the existing unit tests to cover the changes related to job dispatching on the correct connection. Specifically, I've added tests to ensure that the actions in You can run the test cases with the following commands:
|
Hey @abhihyder I've fixed the lint issue and will get this out in the next release. Thanks for the PR 👍 |
Add Job Connections Configuration
Summary
This pull request introduces a new configuration option for setting specific job connections for webhooks, scripttags, and after_authenticate_job.
Details
job_connections
array in the configuration file to allow setting custom job connections for:This change allows developers to define separate job connections for each of these features, enabling better control and customization of their job handling process.
Environment Variables
To utilize the new job connections, the following environment variables can be set:
WEBHOOKS_JOB_CONNECTION
SCRIPTTAGS_JOB_CONNECTION
AFTER_AUTHENTICATE_JOB_CONNECTION
If these variables are not set, the default job connection will be used.
Benefits