Skip to content

Commit

Permalink
add departmental ecs role access the etl bucket
Browse files Browse the repository at this point in the history
  • Loading branch information
Tian-2017 committed Feb 7, 2025
1 parent b923169 commit 43b30db
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 2 deletions.
12 changes: 12 additions & 0 deletions terraform/core/99-outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,15 @@ output "identity_store_id" {
output "arn" {
value = local.sso_instance_arn
}

output "mwaa_etl_scripts_bucket_arn" {
value = aws_s3_bucket.mwaa_etl_scripts_bucket.arn
}

output "mwaa_etl_scripts_bucket_id" {
value = aws_s3_bucket.mwaa_etl_scripts_bucket.id
}

output "mwaa_key_arn" {
value = aws_kms_key.mwaa_key.arn
}
12 changes: 12 additions & 0 deletions terraform/modules/department/01-inputs-required.tf
Original file line number Diff line number Diff line change
Expand Up @@ -132,3 +132,15 @@ variable "redshift_port" {
description = "Port that the redshift cluster is running on"
type = number
}

variable "mwaa_etl_scripts_bucket_arn" {
type = string
}

variable "mwaa_etl_scripts_bucket_id" {
type = string
}

variable "mwaa_key_arn" {
type = string
}
8 changes: 6 additions & 2 deletions terraform/modules/department/50-aws-iam-policies.tf
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ data "aws_iam_policy_document" "s3_department_access" {
var.athena_storage_bucket.kms_key_arn,
var.glue_scripts_bucket.kms_key_arn,
var.spark_ui_output_storage_bucket.kms_key_arn,
var.glue_temp_storage_bucket.kms_key_arn
var.glue_temp_storage_bucket.kms_key_arn,
var.mwaa_key_arn
]
}

Expand Down Expand Up @@ -216,7 +217,10 @@ data "aws_iam_policy_document" "s3_department_access" {
var.glue_temp_storage_bucket.bucket_arn,

var.spark_ui_output_storage_bucket.bucket_arn,
"${var.spark_ui_output_storage_bucket.bucket_arn}/${local.department_identifier}/*"
"${var.spark_ui_output_storage_bucket.bucket_arn}/${local.department_identifier}/*",

var.mwaa_etl_scripts_bucket_arn,
"${var.mwaa_etl_scripts_bucket_arn}/*",
]
}

Expand Down

0 comments on commit 43b30db

Please sign in to comment.