Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: add new types of CodecErrors #135

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Jan 19, 2025

No description provided.

@LDeakin LDeakin added the breaking-changes The PR has API changes label Jan 19, 2025
@LDeakin LDeakin added this to the zarrs 0.20 milestone Jan 19, 2025
Base automatically changed from array_subset_inbounds to main January 19, 2025 05:10
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 24.39024% with 31 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (beecd30) to head (1ef36fe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zarrs/src/array/codec.rs 0.00% 18 Missing ⚠️
zarrs/src/array/codec/bytes_to_bytes/gdeflate.rs 0.00% 8 Missing ⚠️
zarrs/src/array.rs 0.00% 1 Missing ⚠️
zarrs/src/array/array_bytes.rs 85.71% 1 Missing ⚠️
...rc/array/codec/array_to_bytes/bytes/bytes_codec.rs 80.00% 1 Missing ⚠️
zarrs/src/array/codec/array_to_bytes/vlen.rs 0.00% 1 Missing ⚠️
zarrs/src/array/codec/array_to_bytes/vlen_v2.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   81.94%   81.93%   -0.01%     
==========================================
  Files         171      171              
  Lines       24259    24268       +9     
==========================================
+ Hits        19878    19883       +5     
- Misses       4381     4385       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin merged commit f675f06 into main Jan 19, 2025
22 checks passed
@LDeakin LDeakin deleted the refactor_codec_errors branch January 19, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes The PR has API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant