Command-line control over scalar-valued set routines #662
Conversation
drreynolds
requested review from
balos1,
gardner48 and
cswoodward
as code owners
Co-authored-by: Steven Roberts <roberts115@llnl.gov>
… since that causes compilation warnings/errors because main() uses char* argv[].
…uld be matched to process command-line arguments, which should support MRI and operator-splitting
|
I think I've finished revising the previous implementation according to the initial feedback. It would be great if folks who looked at this previously would give it another look. Once you're happy with the structure, I'll get started on the ARKODE stepper-specific functions, other integrators, linear solvers, nonlinear solvers, etc. |
…ber of options in each category. Co-authored-by: Steven Roberts <roberts115@llnl.gov>
include/sundials/priv/sundials_cli.h
Outdated
| @@ -0,0 +1,148 @@ | |||
| /* ----------------------------------------------------------------- | |||
There was a problem hiding this comment.
Can this be moved to src/sundials/sundials_cli.h to limit scope? I don't think any of the declarations are used in include.
There was a problem hiding this comment.
The functions in this file need to be called by each package (ARKODE, CVODE, etc.), so I emulated the structure as we have for sundials_errors.h -- since it's in include/priv it is accessible to all of SUNDIALS but it is not installed for users to call.
There was a problem hiding this comment.
accessible to all of SUNDIALS but it is not installed for users to call.
But it is part of the installed header files (in a subdirectory we hope users ignore).
I would argue that any header for private functions should be in src unless headers in include rely on it. In src, the headers should be just as accessible across the packages. src/sundials/sundials_utils.h is an example of this.
There was a problem hiding this comment.
I hadn't realized that include/sundials/priv/ was actually installed, and I agree that this would optimally not be accessible to users. @balos1 and @gardner48: can you explain why that folder needs to be installed (as opposed to putting these in src/)?
In any case, I'll move this file when I get around to the next batch of command-line updates.
There was a problem hiding this comment.
include/sundials/priv is installed because some header files include function implementations so the "private" error handling functions and macros need to be installed so they're accessible in these functions. If these implementations were made internal then include/sundials/priv could be removed.
Update format for command-line option to call `ARKodeWriteParameters` Co-authored-by: Steven Roberts <roberts115@llnl.gov>
…ble 'larg' as 'large'
I'm opening this up as a draft PR to get feedback on the approach before I update the other packages (CVODE, CVODES, IDA, IDAS, KINSOL), and the various class implementations (
SUNLinearSolver,SUNAdaptController,SUNNonlinearSolver, etc).We can discuss this during an upcoming group meeting, if desired. @balos1 and I have scaled back the previous plans to account for the reduced manpower allocated to the task, so we're only focusing on command-line control for now (YAML or other file-based inputs have been deferred).