Removed 'sanity check' since it only applies to serial runs, although… #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script otherwise supports parallel output
drreynolds
requested review from
balos1,
gardner48 and
cswoodward
as code owners
gardner48
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an incorrect "sanity check" from this python plotting utility script. The script purports to support parallel output, but this check automatically fails for all parallel data files (since the first data file only contains a subdomain).
After removing this incorrect check, the script runs correctly for parallel output (e.g., from
benchmarks/diffusion_2D), while still running correctly for serial output.