-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/592/ccl v3 #595
Issue/592/ccl v3 #595
Conversation
If we are not supporting both v2 and v3 at the same time, I will delete this PR as this is not necessary. However, we will need to update README to specify the maximum or minimum version of CCL supported. |
I don't think it will be feasible to maintain support for both versions. We should just keep track which releases are currently supported. |
Don't know if anyone is using CCL v2.8, but this PR is for them and is ready. We can still wait for the official release of CCL v3. |
@hsinfan1996 do you know if there is an ETA for CCL v3? |
I think there is no exact date for the release of CCL v3. What I know is that before the official release of v3, there are still some tweaks needed on documentation and example notebooks, which can be found here https://github.com/LSSTDESC/CCL/milestone/5. |
74fc5cd
to
2607cda
Compare
CCL v3 will be tagged on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few notebooks that are failing due CCL v3.0 API changes, can you update them?
Paper_v1.0/mcmc.ipynb
Paper_v1.0/validation_tests.ipynb
Paper_v1.0/mass_bias_from_models.ipynb
other_compare_NFW_critical_massdef.ipynb
Thanks
Yes, will do. I thought they should be in the state as when the paper was published for archival purposes. |
That version will still be able to be accessed by going to CLMM v1.0 |
Don't know how to update "examples/Paper_v1.0/mcmc.ipynb". Maybe leave it to issue #606 since it is related to NumCosmo. |
You are right, this is related to NumCosmo |
Somehow cmake is installed from conda instead of conda-forge. Forcing cmake=3.27.4 fixes the GH Actions, but makes solving environment very slow. Can wait a little longer to see if everything fixes itself again. |
Fixed GH Actions by adding |
Not sure why, maybe related to the release of cmake 3.27.5, conda cannot solve the environment consistently and get all packages from conda-forge if |
Only cmake from conda-forge works regardless of the versions. |
On a side note, numpy 1.26 is compatible. |
This will do for now. We can keep an issue to see if it will be solved by a newer version of conda |
tests/data/numcosmo/generate_einasto_hernquist_benchmarks_fromNC.ipynb
demo_mock_ensemble_realistic.ipynb
projected_quad