Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster clustering measurement code #377

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AlessandraFumagalli
Copy link

Wrote code for measuring 2D two-point correlation function of clusters, in richness bins.
Wrote notebook to test the code and validate it against and external code.

…s, in richness bins. Wrote notebook to test the code and validate it against and external code.
AlessandraFumagalli added 3 commits February 7, 2025 11:26
Modified code to read catalogs already binned in redshift and richness.
Updated example notebok to run with the new configuration.
Updated data and random catalogs for validation.
@AlessandraFumagalli AlessandraFumagalli marked this pull request as ready for review February 7, 2025 12:37
Copy link
Collaborator

@joezuntz joezuntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general - see notes below for requested changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be included - it is downloaded by the installer.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an output file which should also not be included.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give the directory here ("clustering_test") a slightly more specific name?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is an output file then you also don't want to include it I think?

@@ -39,6 +39,7 @@
from .lssweights import TXLSSWeights
from .simulation import TXLogNormalGlass
from .magnification import TXSSIMagnification
from .twopoint_cluster import TXTwoPointCluster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we move the twopoint_cluster file (see comment below) then you should also change this.

meanr, xi, varxi, tracer1, tracer2 = result

# Add tracers (placeholders z/Nz values)
s.add_tracer('NZ', tracer1, np.array([1]), np.array([1]))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a placeholder? You can also use a "misc" tracer for this. I think each tracer here is a richness/redshift bin - is that right? We might want to find a way to represent that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants