Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zksync oapp and oft #1181

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

St0rmBr3w
Copy link
Contributor

No description provided.

Copy link

socket-security bot commented Jan 21, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@@ -0,0 +1,25 @@
# @layerzerolabs/onft721-zksync-example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is examples/oapp-zksync but title says onft721

<a href="https://layerzero.network" style="color: #a77dff">Homepage</a> | <a href="https://docs.layerzero.network/" style="color: #a77dff">Docs</a> | <a href="https://layerzero.network/developers" style="color: #a77dff">Developers</a>
</p>

<h1 align="center">ONFT721 Example</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oapp-zksync example, not onft721

],
},
zksolc: {
version: '1.4.1', // Use the latest compatible version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need to be bumped to 1.5.10 or 1.5.11 because 1.4.1 doesn't seem available to download anymore

@@ -0,0 +1,25 @@
# @layerzerolabs/onft721-zksync-example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is oft package not onft

],
},
zksolc: {
version: '1.4.1', // Use the latest compatible version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiler bump required probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants