feat: enable anchor keys sync
auto-replacement by removing program_id_from_env!
#1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
lib.rs
. This creates an opportunity for human error. We have encountered cases where the developer has forgotten to do this. This will not result in an error during program deployment, but will come up when running the init-config/wire commands.anchor keys sync
, which normally would remove the need for the above manual programId replacement. However, it won't auto replace the value since we usePubkey::new_from_array(program_id_from_env!(XXX))
Motivation
If we remove the usage of
program_id_from_env!
, then we can remove the need for manual replacement ofprogramId
, thereby removing once opportunity for human error during development. Replacement is handled by the existinganchor keys sync
command. Improved DevEx unlocked.Changes
program_id_from_env!
fromdeclare_id!