🧹 oft upgradeable example deploy script #1317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old OFT Upgradeable deploy used to assume that the layerzero's internally defined network names founds under
deployments
https://www.npmjs.com/package/@layerzerolabs/lz-evm-sdk-v2?activeTab=code is the same as those defined inhardhat.config.ts
's network config.This isn't the case as developers can name networks differently.
Other examples https://github.com/LayerZero-Labs/devtools/blob/main/examples/oapp/deploy/MyOApp.ts use this pattern where we load the deployments (
EndpointV2
among others) and artifacts intoHardhat
in toolbox-hardhatFor some reason this does not work with Upgradeable which could be due to some internal hardcoding or use of other packages.
The solution is to unabstract the abstraction created by the above code snippet and raw fetch the
EndpointV2
information from the layerzero network name