Merge pull request #187 from LeastAuthority/177.fix-deploy-env

Avoid clean-install to deploy with development env!
LeastAuthority · Feb 4, 2024 · 916d748 · 916d748
2 parents 035d55b + 7516ed7
commit 916d748
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -47,7 +47,7 @@ jobs:
           SFTP_HOSTNAME=${{ secrets.SFTP_HOSTNAME }}
           SFTP_USERNAME=${{ secrets.SFTP_USERNAME }}
           SFTP_IDENTITY="${{ secrets.SFTP_IDENTITY }}"
-          NODE_ENV=production
+          NODE_ENV=development
           ENVIRONMENT=${{ inputs.environment }}
           EOF
           touch ./client-e2e/.env
@@ -66,13 +66,11 @@ jobs:
           CLIENT=0 || CLIENT=1
           # Build image if client is missing
           test $CLIENT -eq 0 || \
-            docker compose --progress plain -f docker-compose.yml -f docker-compose.e2e.yml --profile e2e \
-            build --build-arg uid=$(id -u) --build-arg gid=${_GID} client
+            docker compose --progress plain build --build-arg uid=$(id -u) --build-arg gid=${_GID} client
 
       - name: Prepare containers
         run: |
-          docker compose build --build-arg uid="$(id -u)" --build-arg gid="$(id -g)" client
-          docker compose run --no-deps -e CI=true client npm clean-install
+          docker compose run --rm --no-deps -e CI=true client npm clean-install
 
       - name: Deploy package
         run: docker compose run --no-deps client npm run deploy