Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/aptos coin #248

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

Conversation

joaoccmartins
Copy link
Collaborator

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Comment on lines 10 to 11
valid_destination_1 = "EQD0sKn8DbS12U015TWOSpYmyJYYDC_7sxg1upaMxnBvTiX8"
valid_destination_2 = "EQANxfGN1EgFPawYB1fhPqebKe1Nb6FIsaiekEecJ6R-3kYF"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these need to be valid APT addresses

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they do, but I'm currently hoping for an error actually. Still having trouble getting the system to work at all with the other coins.

test/python/test_aptos.py Outdated Show resolved Hide resolved
test/python/test_aptos.py Outdated Show resolved Hide resolved
from ragger.utils import create_currency_config

APTOS_CONF = create_currency_config("APT", "Aptos")
APTOS_DERIVATION_PATH = "m/44'/607'/0'/0'/0'/0'"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the derivation path for Aptos is m/44'/637'/0'/0'/0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants