Fixes having sys/resource.h and not having the getrlimit function #633
Conversation
Manually resolved conflicts: x11vnc/util.c
…tipointer mode. Right now this is used in pointer.c and uinput.c, other files still have to be reworked, especially userinput.c with the XRECORD and wireframe stuff...
…arg. This is for instance the case when the core pointer is meant. Fixes lots of potential segfaults.
This redirects ambigious Xlib calls to the virtual core pointer.
Now every pixel-format and encoding combination has continuous sequence numbering. Before messages were counted unaware of pixel-format and encoding combination, leaving clients with the impression of huge holes in the sequence.
Conflicts, resolved: rfb/rfb.h
32 byte are needed to store 255 values simultaneously.
The regions of partial updates are the same with every pixel-format and encoding combination, so save them only once. Before, several partial updates with the same sequence number were stored, rendering the NACK mechanism broke.
This now resends NACKes partial updates to clients instead of just marking the NACKed regions as modified in the next multicast framebuffer update. This way the client side counting of lost messages is way more near to reality.
Conflicts: libvncserver/sockets.c
Using 'aNULL' enables anonymous Elliptic Curve cipher suits. It improves compatibility with some TLS libraries, e.g. GnuTLS. Ref: https://www.openssl.org/docs/man1.1.1/man1/ciphers.html
…`getrlimit` function.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| int y = rect.y1; | ||
| int w = rect.x2 - x; | ||
| int h = rect.y2 - y; | ||
| size_t maxSizeRect = w * h * 4; |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
|
I am not sure why the commit history looks like that. all I did was fork the repo, clone my local copy. prior to making a new branch I pulled any changes from your master branch and pushed them to my fork. then I created the new branch and made the code changes and committed them and pushed them to the new branch on my fork. then opened the PR and this is what resulted. Never seen this happen before as that is the way I have always handled making a PR. I think you can merge this and squash it so it doesn't muddy the commit history. IDK. this has never happened to me before. |
|
@kdschlosser looks a bit like you cloned the multicastvnc branch and now this PR wants to merge it back. Please try force-pushing or maybe a new PR, both welcome. Can't merge in the current form. |
|
I will mess about with it and see what is going on. I am not sure why it ended up like this. I might have to clone the repo over again and make all of the changes again that I have made. |
This fixes a compilation error that can occur if the
sys/resource.hfile does exist but thegetrlimitfunction doesn't.