Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bq769x0: Refactor read functions and fix CRC calculation #55

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

martinjaeger
Copy link
Member

@martinjaeger martinjaeger commented Feb 20, 2024

Use the same function for reading bytes and words.

Fixes #53

Testing with hardware still to be done.

@martinjaeger martinjaeger force-pushed the bq769x0-fix-crc-calculation branch from 4022eca to d197654 Compare February 21, 2024 16:04
Use the same function for reading bytes and words.

Fixes #53
Copy link

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@martinjaeger martinjaeger merged commit d197654 into main Feb 21, 2024
2 checks passed
@martinjaeger martinjaeger deleted the bq769x0-fix-crc-calculation branch February 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bq769x0: repeat read due to crc fail might read different bytes an might led to wrong data read
2 participants