Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to fix indicator panel issue #337

Merged
merged 22 commits into from
Feb 3, 2025
Merged

Conversation

laisspportugal
Copy link
Contributor

@laisspportugal laisspportugal commented Jan 24, 2025

User-Facing Changes

This PR addresses an issue with the font size on the Indicator Panel, where the font appeared too large and did not adjust properly when resizing the application window.

Description

It was caused by the new Electron 33.2.1. It was needed to adapt the styles of Indicator component.

Checklist

  • The web version has been tested and is functioning correctly.
  • The desktop version has been tested and is functioning correctly.
  • Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated

@laisspportugal laisspportugal added the bug Something isn't working label Jan 24, 2025
@laisspportugal laisspportugal marked this pull request as draft January 24, 2025 17:20
@laisspportugal laisspportugal marked this pull request as ready for review January 27, 2025 11:57
@luluiz
Copy link
Member

luluiz commented Jan 27, 2025

Have you tested the indicator with bulb mode?

luluiz
luluiz previously approved these changes Jan 27, 2025
Copy link
Contributor

@aneuwald-ctw aneuwald-ctw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion to remove a mock that has not being used. If you think it is important, I already approved the rest, if you realize that you can remove it, please remove and I will approve again.

@laisspportugal laisspportugal merged commit d655adc into main Feb 3, 2025
11 checks passed
@laisspportugal laisspportugal deleted the bugfix/indicator-panel branch February 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants