forked from base-org/node
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lisk node repository to use data from superchain registry #48
Merged
sameersubudhi
merged 7 commits into
main
from
LISK-1114-Update-lisk-node-repository-to-use-data-from-Superchain-Registry
Nov 23, 2024
Merged
Update lisk node repository to use data from superchain registry #48
sameersubudhi
merged 7 commits into
main
from
LISK-1114-Update-lisk-node-repository-to-use-data-from-Superchain-Registry
Nov 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matjazv
reviewed
Nov 22, 2024
matjazv
reviewed
Nov 22, 2024
matjazv
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both Geth and Reth!
LGTM! Nice job! 🚀
Incede
requested changes
Nov 22, 2024
Incede
approved these changes
Nov 22, 2024
sameersubudhi
deleted the
LISK-1114-Update-lisk-node-repository-to-use-data-from-Superchain-Registry
branch
November 23, 2024 07:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #LISK-1114 and #LISK-1306
How was it solved?
How was it tested?
Locally against both testnet & mainnet with the following clients