Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lisk node repository to use data from superchain registry #48

Conversation

sameersubudhi
Copy link
Member

@sameersubudhi sameersubudhi commented Nov 22, 2024

What was the problem?

This PR resolves #LISK-1114 and #LISK-1306

How was it solved?

  • Remove unused rollup.json config for both mainnet and sepolia
  • Bump node dependencies
  • Update entrypoint scripts
  • Update default environment files
  • Update .gitignore
  • Update README

How was it tested?

Locally against both testnet & mainnet with the following clients

  • op-geth
  • op-reth

.env.sepolia Outdated Show resolved Hide resolved
geth/Dockerfile Show resolved Hide resolved
reth/reth-entrypoint Outdated Show resolved Hide resolved
Copy link

@matjazv matjazv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both Geth and Reth!
LGTM! Nice job! 🚀

README.md Show resolved Hide resolved
@sameersubudhi sameersubudhi requested a review from Incede November 22, 2024 22:33
@sameersubudhi sameersubudhi merged commit 3990684 into main Nov 23, 2024
4 checks passed
@sameersubudhi sameersubudhi deleted the LISK-1114-Update-lisk-node-repository-to-use-data-from-Superchain-Registry branch November 23, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants