👌 Applied suggestions

cmd/faultdetector/main_test.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"io"
 	"math/big"
+	"math/rand"
 	"net/http"
 	"strconv"
 	"strings"
@@ -30,13 +31,14 @@ import (
 )
 
 const (
-	host                       = "127.0.0.1"
-	port                       = 8088
-	faultProofWindow           = 1000
-	currentOutputIndex         = 1
-	l1RpcApi                   = "https://rpc.notadegen.com/eth"
-	l2RpcApi                   = "https://mainnet.optimism.io/"
-	faultDetectorStateMismatch = "fault_detector_is_state_mismatch"
+	host                                = "127.0.0.1"
+	port                                = 8088
+	faultProofWindow                    = 1000
+	currentOutputIndex                  = 1
+	l1RpcApi                            = "https://rpc.notadegen.com/eth"
+	l2RpcApi                            = "https://mainnet.optimism.io/"
+	faultDetectorStateMismatchMetricKey = "fault_detector_is_state_mismatch"
+	metricValue                         = "value"
 )
 
 type parseMetric map[string]map[string]interface{}
@@ -76,6 +78,11 @@ func randHash() (out common.Hash) {
 	return out
 }
 
+func randTimestamp() (out uint64) {
+	timestamp := uint64(rand.Int63n(time.Now().Unix()))
+	return timestamp
+}
+
 func prepareHTTPServer(t *testing.T, ctx context.Context, logger log.Logger, config *config.Config, wg *sync.WaitGroup, erroChan chan error) *api.HTTPServer {
 	testServer := api.NewHTTPServer(ctx, logger, wg, config, erroChan)
 	return testServer
@@ -106,13 +113,13 @@ func prepareFaultDetector(t *testing.T, ctx context.Context, logger log.Logger,
 		oracle.On("FinalizationPeriodSeconds").Return(faultProofWindow, nil)
 		oracle.On("GetL2Output", big.NewInt(0)).Return(chain.L2Output{
 			OutputRoot:    randHash().String(),
-			L1Timestamp:   1000000,
+			L1Timestamp:   randTimestamp(),
 			L2BlockNumber: latestL2BlockNumber,
 			L2OutputIndex: 2,
 		}, nil)
 		oracle.On("GetL2Output", big.NewInt(1)).Return(chain.L2Output{
 			OutputRoot:    randHash().String(),
-			L1Timestamp:   1000000,
+			L1Timestamp:   randTimestamp(),
 			L2BlockNumber: latestL2BlockNumber,
 			L2OutputIndex: 2,
 		}, nil)
@@ -166,9 +173,9 @@ func parseMetricRes(input *strings.Reader) []parseMetric {
 			}
 			switch metricFamily.GetType() {
 			case promClient.MetricType_COUNTER:
-				metric["value"] = m.GetCounter().GetValue()
+				metric[metricValue] = m.GetCounter().GetValue()
 			case promClient.MetricType_GAUGE:
-				metric["value"] = m.GetGauge().GetValue()
+				metric[metricValue] = m.GetGauge().GetValue()
 			}
 			parsedOutput = append(parsedOutput, parseMetric{
 				metricFamily.GetName(): metric,
@@ -250,8 +257,8 @@ func TestMain_E2E(t *testing.T) {
 				assert.NoError(t, err)
 				parsedMetric := parseMetricRes(strings.NewReader(string(body)))
 				for _, m := range parsedMetric {
-					if m[faultDetectorStateMismatch] != nil {
-						isStateMismatch := m[faultDetectorStateMismatch]["value"].(float64)
+					if m[faultDetectorStateMismatchMetricKey] != nil {
+						isStateMismatch := m[faultDetectorStateMismatchMetricKey][metricValue].(float64)
 						tt.assertion(isStateMismatch, nil)
 					}
 				}