♻️ Fix test and mocking

LiskHQ · Jan 18, 2024 · 9c989ff · 9c989ff
1 parent d614860
commit 9c989ff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/pkg/chain/chain_mocks_test.go b/pkg/chain/chain_mocks_test.go
@@ -9,7 +9,6 @@ import (
 	"github.com/stretchr/testify/mock"
 )
 
-// Mock function
 type MockAPIClient struct {
 	mock.Mock
 }
@@ -40,7 +39,9 @@ type MockRPCClient struct {
 }
 
 func (c *MockRPCClient) Call(result interface{}, method string, args ...interface{}) error {
-	ret := c.Called()
+	allArgs := []interface{}{result, method}
+	allArgs = append(allArgs, args...)
+	ret := c.Called(allArgs...)
 
 	ptr := &result
 	*ptr = ret.Get(0)

diff --git a/pkg/chain/chain_test.go b/pkg/chain/chain_test.go
@@ -11,10 +11,7 @@ import (
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/core/types"
 	"github.com/stretchr/testify/assert"
-)
-
-const (
-	fake_url = "localhost:8080"
+	"github.com/stretchr/testify/mock"
 )
 
 func TestNewChainAPIClient(t *testing.T) {
@@ -85,9 +82,10 @@ func TestGetProof(t *testing.T) {
 	var proofResponseExpected ProofResponse
 
 	apiClientMock.On("Client").Return(rpcClientMock, nil)
-	rpcClientMock.On("Call", &proofResponseExpected, RPCEndpointGetProof, address.String(), []string{}, blockNumber).Return(fmt.Println("Error"))
+	rpcClientMock.On("Call", mock.AnythingOfType("*chain.ProofResponse"), RPCEndpointGetProof, address.String(), []string{}, blockNumber).Return(fmt.Println("Error"))
 
-	proofResponseRecieved, _ := chainClient.GetProof(rpcClientMock, blockNumber, address.Hex())
+	proofResponseRecieved, err := chainClient.GetProof(rpcClientMock, blockNumber, address.Hex())
 
-	assert.Equal(t, proofResponseExpected, proofResponseRecieved)
+	assert.NoError(t, err)
+	assert.Equal(t, &proofResponseExpected, proofResponseRecieved)
 }