Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeJS support #118

Merged
merged 81 commits into from
Jan 19, 2025
Merged

Add NodeJS support #118

merged 81 commits into from
Jan 19, 2025

Conversation

kevinheavey
Copy link
Collaborator

@kevinheavey kevinheavey commented Jan 13, 2025

The only change to existing crates is that the LiteSVM struct now has internal methods like set_compute_budget. This is because napi-rs couldn't call the with_* methods, so I needed a way to mutate the struct without returning it.

New stuff:

  • Add litesvm-node crate and litesvm TypeScript package
  • Add docs site for this package
  • Add CI for this package

@kevinheavey kevinheavey marked this pull request as ready for review January 13, 2025 15:58
@kevinheavey kevinheavey requested a review from Aursen January 13, 2025 15:59
Copy link
Collaborator

@Aursen Aursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of the previous comment, everything looks good with a good doc.

Thanks a lot

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to put multiple git ignore in the repo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came from a preset, but it does have some stuff we need in there, and there's little benefit to merging them so I suggest we just leave it as is

@Aursen Aursen self-requested a review January 19, 2025 19:38
@kevinheavey kevinheavey merged commit 4f00b0d into master Jan 19, 2025
11 checks passed
@Aursen Aursen deleted the napi branch January 20, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants