Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trainer): custom trainer #87

Merged
merged 8 commits into from
Jan 15, 2025
Merged

fix(trainer): custom trainer #87

merged 8 commits into from
Jan 15, 2025

Conversation

LongxingTan
Copy link
Owner

Description

This PR ...

Checklist

  • Linked issues (if existing)
  • Amended changelog.md for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Thank you for joining. Have fun coding!

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 84.49612% with 20 lines in your changes missing coverage. Please review.

Project coverage is 55.37%. Comparing base (bcbf148) to head (30a69cb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/retrievals/trainer/custom_trainer.py 83.47% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   51.98%   55.37%   +3.39%     
==========================================
  Files          38       38              
  Lines        2826     2725     -101     
==========================================
+ Hits         1469     1509      +40     
+ Misses       1357     1216     -141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LongxingTan LongxingTan merged commit 3d9e9ea into master Jan 15, 2025
12 checks passed
@LongxingTan LongxingTan deleted the fix/benchmark29 branch January 15, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant