Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ranking): clean the code #89

Merged
merged 14 commits into from
Jan 16, 2025
Merged

refactor(ranking): clean the code #89

merged 14 commits into from
Jan 16, 2025

Conversation

LongxingTan
Copy link
Owner

Description

This PR ...

Checklist

  • Linked issues (if existing)
  • Amended changelog.md for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Thank you for joining. Have fun coding!

Repository owner deleted a comment from codecov bot Jan 16, 2025
@LongxingTan LongxingTan merged commit 1b72e5e into master Jan 16, 2025
11 checks passed
@LongxingTan LongxingTan deleted the fix/llm branch January 16, 2025 13:23
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 65.70048% with 71 lines in your changes missing coverage. Please review.

Project coverage is 56.54%. Comparing base (56d9153) to head (115a5f4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/retrievals/models/rerank.py 55.42% 37 Missing ⚠️
src/retrievals/models/base.py 70.37% 24 Missing ⚠️
src/retrievals/models/utils.py 75.60% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   55.34%   56.54%   +1.19%     
==========================================
  Files          39       39              
  Lines        2768     2773       +5     
==========================================
+ Hits         1532     1568      +36     
+ Misses       1236     1205      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant