-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOLfYN Teledyne River depth #368
Comments
Hey @browniea, thanks for bringing this up.
|
Close #375 |
Partial solution for Issue #368. Fixes an issue with a changing `bin1_dist_m` attribute, which was presumed constant before. Also solves an issue with changing surface layer cell sizes. The RDI reader will now also explicitly return the `range_offset` that the user programmed into the instrument.
PR #378 should officially solve this bug, which I didn't originally see, involving the changing depth cell sizes that the RiverPro/StreamPro firmware creates. I've removed RDI's "bin1_dist_m" and replaced it the dolfyn agnostic "range_offset", so the user knows how far the range coordinate is offset based on the ADCP's submerged depth. |
The "river depth" output from WinRiver appears to have an offset or different reference that can be validated with the bathymetry data.

I was looking in the user guide here for "river depth" WinRiver II user guide There are a few different refences the river depth can be using. DOLfYN might not be using the right one.
WinRiver River Depth comparted to
mhkit.river.d3d
This plot shows that the MHKiT river d3d module matches the output from WinRiver

mhkit.dolfyn
River Depth comparted tomhkit.river.d3d
This plot shows that the DOLfYN ADCP has an offset to the ADCP variable

dist_bt
read in by DOLfYNI expect DOLfYN river D3D should match WinRiver and MHKiT in this case.
The text was updated successfully, but these errors were encountered: