Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOLfYN Teledyne River depth #368

Closed
browniea opened this issue Dec 19, 2024 · 3 comments
Closed

DOLfYN Teledyne River depth #368

browniea opened this issue Dec 19, 2024 · 3 comments
Assignees
Labels
bug Something isn't working dolfyn module

Comments

@browniea
Copy link
Contributor

browniea commented Dec 19, 2024

The "river depth" output from WinRiver appears to have an offset or different reference that can be validated with the bathymetry data.
I was looking in the user guide here for "river depth" WinRiver II user guide There are a few different refences the river depth can be using. DOLfYN might not be using the right one.
image001

WinRiver River Depth comparted to mhkit.river.d3d

This plot shows that the MHKiT river d3d module matches the output from WinRiver
image003

mhkit.dolfyn River Depth comparted to mhkit.river.d3d

This plot shows that the DOLfYN ADCP has an offset to the ADCP variable dist_bt read in by DOLfYN
image004

I expect DOLfYN river D3D should match WinRiver and MHKiT in this case.

@browniea browniea added the bug Something isn't working label Dec 19, 2024
@jmcvey3
Copy link
Contributor

jmcvey3 commented Dec 30, 2024

Hey @browniea, thanks for bringing this up.
Any raw variables that dolfyn reads are what is directly stored in the raw file. A couple things to check:

  1. 'dist_bt' should be a 4x vector with one time-series per beam - if the boat is pitching and rolling you'll probably want to use the minimum distance rather than the average
  2. If the ADCP has an altimeter ping, consider using that distance instead (another dist_ variable). There's usually some disparity between them
  3. Make sure you're taking the depth of the ADCP transducers below the vessel into account before plotting

@ssolson ssolson mentioned this issue Feb 4, 2025
@ssolson
Copy link
Contributor

ssolson commented Feb 6, 2025

Close #375

@ssolson ssolson closed this as completed Feb 6, 2025
jmcvey3 added a commit that referenced this issue Feb 17, 2025
Partial solution for Issue #368. Fixes an issue with a changing `bin1_dist_m` attribute, which was presumed constant before. Also solves an issue with changing surface layer cell sizes. The RDI reader will now also explicitly return the `range_offset` that the user programmed into the instrument.
@jmcvey3
Copy link
Contributor

jmcvey3 commented Feb 17, 2025

PR #378 should officially solve this bug, which I didn't originally see, involving the changing depth cell sizes that the RiverPro/StreamPro firmware creates. I've removed RDI's "bin1_dist_m" and replaced it the dolfyn agnostic "range_offset", so the user knows how far the range coordinate is offset based on the ADCP's submerged depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dolfyn module
Projects
None yet
Development

No branches or pull requests

3 participants