Fix ever-changing RDI RiverPro depth bin ranges #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d range offset to attributes
…ge_offset'; only save global attributes in reader into 'cfg' dictionary
…ile for range fixes
ssolson
approved these changes
Feb 13, 2025
| @@ -949,7 +955,7 @@ def reshape(self, arr, n_bin=None): | |||
|
|
|||
| return out | |||
|
|
|||
| def finalize(self, dat): | |||
| def finalize(self, dat, cfg): | |||
There was a problem hiding this comment.
need to add cfg to docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial solution for Issue #368. Fixes an issue with a changing
bin1_dist_mattribute, which was presumed constant before. Also solves an issue with changing surface layer cell sizes.The RDI reader will now also explicitly return the
range_offsetthat the user programmed into the instrument.