-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bldgRealEstateIDAttribute を Building に直接含める #121
Conversation
Walkthroughこの変更は、不動産と大型顧客施設に関連するセマンティック構造に影響を与える Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#120 による不動産IDの対応では、不動産IDまわりの属性をBuildingとは別のテーブルに収める形で対応した。
しかし bldg:Building/uro:bldgRealEstateIDAttribute は、多重度が [0..1] であるため、Building のカラムとして直接持たせることもできる。このPRはそのような読み込み方法に変更する。
また、以下2つのプロパティ値の型を
[]string
に変更する:uro:realEstateIDOfBuilding
uro:realEstateIDOfBuildingUnitOwnership
Summary by CodeRabbit
REAL_ESTATE_ID_ATTRIBUTE
宣言を削除しました。uro:bldgRealEstateIDAttribute
を削除し、realEstateIDOfBuilding
、numberOfBuildingUnitOwnership
などのさまざまな属性を含む新しい属性グループAttributeGroup
に置き換えました。