Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bldgRealEstateIDAttribute を Building に直接含める #121

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

ciscorn
Copy link
Member

@ciscorn ciscorn commented Mar 18, 2024

#120 による不動産IDの対応では、不動産IDまわりの属性をBuildingとは別のテーブルに収める形で対応した。

しかし bldg:Building/uro:bldgRealEstateIDAttribute は、多重度が [0..1] であるため、Building のカラムとして直接持たせることもできる。このPRはそのような読み込み方法に変更する。

また、以下2つのプロパティ値の型を []string に変更する:

  • uro:realEstateIDOfBuilding
  • uro:realEstateIDOfBuildingUnitOwnership

Untitled

Summary by CodeRabbit

  • リファクタ
    • 建物および大規模顧客施設の属性に関連するセマンティック構造からREAL_ESTATE_ID_ATTRIBUTE宣言を削除しました。
    • 建物の詳細に関連する属性グループに大きな変更を加え、uro:bldgRealEstateIDAttributeを削除し、realEstateIDOfBuildingnumberOfBuildingUnitOwnershipなどのさまざまな属性を含む新しい属性グループAttributeGroupに置き換えました。

@ciscorn ciscorn requested a review from kntoshiya March 18, 2024 11:54
@ciscorn ciscorn self-assigned this Mar 18, 2024
Copy link

coderabbitai bot commented Mar 18, 2024

Walkthrough

この変更は、不動産と大型顧客施設に関連するセマンティック構造に影響を与えるREAL_ESTATE_ID_ATTRIBUTE宣言の削除、および建物データモデルの再構築を伴います。具体的には、uro:bldgRealEstateIDAttributeの削除と、新しい属性グループAttributeGroupへの置き換えが行われています。

Changes

ファイル 変更概要
.../__init__.py REAL_ESTATE_ID_ATTRIBUTE宣言の削除
.../building.py uro:bldgRealEstateIDAttributeの削除と、新しい属性グループAttributeGroupの追加

🐰✨
属性は変われど、建物はそのまま
新しいID、新たな始まり
コードの中に隠された物語
データの海を泳ぐ小さな船
変化を祝う、一匹の兎からの詩


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 47c96d9 and f49936f.
Files selected for processing (2)
  • plateau_plugin/plateau/models/init.py (2 hunks)
  • plateau_plugin/plateau/models/building.py (3 hunks)

Copy link
Contributor

@kntoshiya kntoshiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kntoshiya kntoshiya merged commit 61482de into main Mar 18, 2024
4 checks passed
@kntoshiya kntoshiya deleted the realestate-id-on-building branch March 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants